Add integration tests and config parser helper#545
Open
Georgechisom wants to merge 1 commit into
Open
Conversation
- Add integration test for creator holders endpoint with invalid creator ID formats - Add integration test for webhook registration with invalid/missing signatures - Add integration test for wallet activity endpoint with malformed Stellar addresses - Add parsePositiveInt helper for safe env config parsing with unit tests Closes accesslayerorg#537, accesslayerorg#539, accesslayerorg#536, accesslayerorg#535
|
@Georgechisom Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Integration Tests and Config Parser Helper
This PR adds validation integration tests and a safe environment config parser helper to improve validation coverage and startup configuration handling.
Changes
Integration Tests Added:
Config Parser Helper:
parsePositiveIntutility for safely parsing positive integer values from environment variablesTesting
All new tests verify that validation errors return 400 with descriptive messages before database queries execute.
Closes #537
Closes #539
Closes #536
Closes #535