Feat/stellar trade event parser#526
Open
Godfrey-Delight wants to merge 3 commits into
Open
Conversation
Implemented a try/catch inside evaluatePriceAlertsForMovement (src/modules/alerts/alert.service.ts:132) that emits a structured logger.error with creator_id, ledger_sequence, new_price, error_message, and failed_at when the alert threshold check fails (e.g., database error reading alerts). Added optional ledger_sequence to the PriceMovement type so the log carries enough context for an operator to replay the check. The error is re-thrown after logging so existing error propagation is preserved. New tests verify the log is emitted with all fields on DB failure and is not emitted on success. Closed accesslayerorg#510
…e event schema Added `parseStellarTradeEvent(rawEvent: RawSorobanEvent): TradeEvent` in `src/utils/stellar-trade-event-parser.utils.ts` that maps decoded Soroban event fields to the server's trade schema, validates all required fields, maps `KEY_BOUGHT`/`KEY_SOLD` to `buy`/`sell`, and throws a typed `ParseError` on missing or invalid input. 10 unit tests cover valid buy/sell events, missing fields, unknown event types, invalid JSON, non-numeric ledger, and empty timestamps. Closed accesslayerorg#513
|
@Godfrey-Delight Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added
parseStellarTradeEvent(rawEvent: RawSorobanEvent): TradeEventinsrc/utils/stellar-trade-event-parser.utils.tsthat maps decoded Soroban event fields to the server's trade schema, validates all required fields, mapsKEY_BOUGHT/KEY_SOLDtobuy/sell, and throws a typedParseErroron missing or invalid input. 10 unit tests cover valid buy/sell events, missing fields, unknown event types, invalid JSON, non-numeric ledger, and empty timestampsClosed #513
Testing
pnpm lintpnpm buildpnpm exec prisma generatewhen schema or generated types changedChecklist