test(#500): add regression test for slippage protection on sell at exact min_proceeds boundary#507
Open
BWM0223 wants to merge 1 commit into
Open
test(#500): add regression test for slippage protection on sell at exact min_proceeds boundary#507BWM0223 wants to merge 1 commit into
BWM0223 wants to merge 1 commit into
Conversation
… on sell at exact min_proceeds boundary
Author
|
Implementation complete and ready for review. Payment wallets ready: ETH 0xeaCAb48a4bfA0CED0e668c166615927115655594 | SOL C3MD2yfWYebB8FYXpq6ooqzU5GCQB1bDxbDhQf1JfiCW | BTC bc1qtmlgtvg7xgv0zry3ct90elp3y7d3ffdutk4e2f |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #500
2 tests in
creator-keys/tests/slippage_sell_boundary.rs:sell_succeeds_when_proceeds_equal_min_proceeds_exactly- boundary must passsell_reverts_when_proceeds_below_min- strict below must revertPayment: ETH 0xeaCAb48a4bfA0CED0e668c166615927115655594