fix: apply focus-visible ring styles to marketplace CreatorCard#512
Merged
Merged
Conversation
|
@N-i-xx Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Implements missing keyboard accessibility for marketplace grid items (CreatorCard) by introducing a clear, distinct focus-visible interactive indicator, ensuring seamless navigation for assistive technologies and keyboard users.
Changes Made
Interactive Element: Added an explicit keyboard accessibility attribute (tabIndex={0}) to the outer wrapper card div to ensure it participates correctly in the document's sequential focus navigation.
Focus Ring System: Integrated the project's standardized Tailwind focus rings (focus-visible:ring-2 focus-visible:outline-none) to generate a clean, clear visual outline.
Pointer Isolation: Specifically utilized focus-visible to isolate keyboard interaction triggers, ensuring that normal mouse clicks or touch gestures do not accidentally display a persistent focus outline.
Acceptance Criteria Verified
[x] Navigating through the marketplace grid using a keyboard reveals a distinct, visible focus ring around the focused item.
[x] Triggering or selecting the element via a pointer/mouse click completely suppresses the focus outline to preserve the intentional layout design.
[x] Visual focus indicator styling perfectly mirrors existing focus indicators used across other areas of the application UI.
closes #383