Add integration test for holder count display updating after React Qu…#509
Merged
Conversation
…ery cache invalidation
|
@Johnpii1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ery cache invalidation
Summary
Description
Introduce a shared query key CREATOR_LIST_QUERY_KEY and move creator list fetching on the landing page to useQuery so query invalidation triggers refetches.
Surface live holder counts by adding holderCount?: number to the Course type and using featuredCreator.holderCount (with existing fallbacks) for the Audience chip.
Add an integration test that renders the landing page with a test QueryClient, mocks an initial holderCount, invalidates the creator query, mocks a refetch returning an updated holderCount, and asserts the UI shows the new count and the old count is gone.
Testing
Testing
Ran the focused integration test with pnpm exec vitest run src/pages/tests/LandingPage.keyboard.test.tsx and it passed.
Ran linting with pnpm exec eslint src/pages/LandingPage.tsx src/services/course.service.ts src/pages/tests/LandingPage.keyboard.test.tsx and it passed.
Ran type checks with pnpm exec tsc -b --pretty false and it passed.
pnpm lintpnpm buildChecklist
close #480