Simplify control_by_id API: remove view parameter from t_arg#694
Merged
Conversation
Drop the positional view slot from control_by_id t_arg in follow_up_action and _event_client calls; pass the view via the new view parameter where it is not the main view (app 170: cs_view-popup). Main-view calls simply omit the slot. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ar8FTqFRTaZ9r5jcje9J9n
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the
control_by_idevent API to remove the explicit view parameter from the positionalt_argarray. The view now defaults tocs_view-mainand can be specified separately via an optionalviewparameter when needed.Key Changes
API Simplification: Removed the view identifier (second position) from
t_argin allcontrol_by_idfollow-up action calls across demo apps 202, 447, 448, 449, and 465t_arg = VALUE #( ( id ) ( view ) ( method ) ( params... ) )t_arg = VALUE #( ( id ) ( method ) ( params... ) )Explicit View Parameter: Updated demo app 170 to use the new
viewparameter explicitly when targeting non-main views (e.g.,view = client->cs_view-popup)Documentation Updates: Clarified inline comments across all modified files to reflect that:
cs_view-maint_argis now positional with id, method, and params onlyImplementation Details
MAINview identifier from navigation control callviewparameter for popup view targetingt_argarrays by removing empty string ("") or explicit view identifiershttps://claude.ai/code/session_01Ar8FTqFRTaZ9r5jcje9J9n