Skip to content

Drop cryptography dependencies check#82

Open
jas4711 wants to merge 1 commit into
Yubico:mainfrom
jas4711:accept-cryptography-47
Open

Drop cryptography dependencies check#82
jas4711 wants to merge 1 commit into
Yubico:mainfrom
jas4711:accept-cryptography-47

Conversation

@jas4711

@jas4711 jas4711 commented Jun 24, 2026

Copy link
Copy Markdown

No description provided.

@jas4711 jas4711 force-pushed the accept-cryptography-47 branch from 1ac4bb1 to af3faf2 Compare June 24, 2026 11:02
@jas4711

jas4711 commented Jun 24, 2026

Copy link
Copy Markdown
Author

I noticed this problem independently of #83 but I agree with @cjwatson that the cryptography version check is probably unnecessary, so aligning this merge request with that

@jas4711 jas4711 changed the title Bump cryptography dependencies to <48 Drop cryptography dependencies check Jun 24, 2026
@dainnilsson

Copy link
Copy Markdown
Member

Thanks for pointing out the issue, we are overdue for a new release of the library,even if it is just a dependency version bump. That said, the upper bound is in place to ensure compatibility and we do take care to test the latest supported version when we make a new release. Cryptography uses a versioning scheme where if a feature exists and does not emit a deprecation warning in version X, it is guaranteed to still be available in X+2. Thus, if we test and ensure compatibility (and no usage of deprecated functions) with version Y, we will set the requirement to be < Y+3.

Given that the latest version of cryptography is currently 49, we need to fully test this version and then bump the requirement to <52. That, and create a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants