Rolltracker: Fix Lucky Number reporting logic and missing BUST! color#2555
Open
SnickySnacks wants to merge 1 commit into
Open
Rolltracker: Fix Lucky Number reporting logic and missing BUST! color#2555SnickySnacks wants to merge 1 commit into
SnickySnacks wants to merge 1 commit into
Conversation
Currently lucky numbers are reported every other roll/double. This means if you do roll A and hit a lucky number, then do roll B, roll B won't report its lucky numbers. This commit changes that logic to always report them on the first roll, based on the rollID changing or the rollNum going down (if doing the same roll multiple times) Minor bugs are that if the first roll is low and you wait/fold the roll and then re-roll the same roll and get a number higher than the first roll, the lucky numbers won't display again. Based on the method this addon is using, I don't think I can differentiate between phantom roll and double-up in this scenario to determine when this occurs. Also, if you double-up on a non-11 lucky number, it will print the lucky numbers again, as I'm resetting the reporting flag when the lucky number is hit, to help a *little* with the first scenario.
SnickySnacks
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently lucky numbers are reported every other roll/double. This means if you do roll A and hit a lucky number, then do roll B, roll B won't report its lucky numbers until you double up.
This commit changes that logic to always report them on the first roll, based on the rollID changing or the rollNum going down (if doing the same roll multiple times)
Minor bugs are that if the first roll is low and you wait/fold the roll and then re-roll the same roll and get a number higher than the first roll, the lucky numbers won't display again. Based on the method this addon is using, I don't think I can differentiate between phantom roll and double-up in this scenario to determine when this occurs.
Also, if you double-up on a non-11 lucky number, it will print the lucky numbers again, as I'm resetting the reporting flag when the lucky number is hit, to help a little with the first scenario.