-
Notifications
You must be signed in to change notification settings - Fork 0
chore: willboosterify this repo #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -21,6 +21,8 @@ | |||||
| - Always create new commits; avoid `--amend`. | ||||||
| - Use heredoc for multi-line command input (e.g., `git commit -F -`, `gh pr create --body-file -`). | ||||||
| - Put temporary files in `.tmp`; use `/tmp` only for files that must live outside the repo. | ||||||
| - Tool versions (node, bun, and others) are pinned in `mise.toml`; run `mise install` after changing it, and never install those tools globally instead. | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The word 'instead' at the end of the sentence is redundant. Removing it simplifies the instruction and makes it more direct, adhering to the style guide rule to eliminate redundancy.
Suggested change
References
|
||||||
| - `bunfig.toml` uses Bun's isolated linker with a global store, so only declared dependencies resolve. If an import fails to resolve, declare that package in the `package.json` that imports it; never switch `linker` to `hoisted` or add to `publicHoistPattern` to work around it. | ||||||
|
|
||||||
| ## Coding Style | ||||||
|
|
||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -21,6 +21,8 @@ | |||||
| - Always create new commits; avoid `--amend`. | ||||||
| - Use heredoc for multi-line command input (e.g., `git commit -F -`, `gh pr create --body-file -`). | ||||||
| - Put temporary files in `.tmp`; use `/tmp` only for files that must live outside the repo. | ||||||
| - Tool versions (node, bun, and others) are pinned in `mise.toml`; run `mise install` after changing it, and never install those tools globally instead. | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The word 'instead' at the end of the sentence is redundant. Removing it simplifies the instruction and makes it more direct, adhering to the style guide rule to eliminate redundancy.
Suggested change
References
|
||||||
| - `bunfig.toml` uses Bun's isolated linker with a global store, so only declared dependencies resolve. If an import fails to resolve, declare that package in the `package.json` that imports it; never switch `linker` to `hoisted` or add to `publicHoistPattern` to work around it. | ||||||
|
|
||||||
| ## Coding Style | ||||||
|
|
||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -21,6 +21,8 @@ | |||||
| - Always create new commits; avoid `--amend`. | ||||||
| - Use heredoc for multi-line command input (e.g., `git commit -F -`, `gh pr create --body-file -`). | ||||||
| - Put temporary files in `.tmp`; use `/tmp` only for files that must live outside the repo. | ||||||
| - Tool versions (node, bun, and others) are pinned in `mise.toml`; run `mise install` after changing it, and never install those tools globally instead. | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The word 'instead' at the end of the sentence is redundant. Removing it simplifies the instruction and makes it more direct, adhering to the style guide rule to eliminate redundancy.
Suggested change
References
|
||||||
| - `bunfig.toml` uses Bun's isolated linker with a global store, so only declared dependencies resolve. If an import fails to resolve, declare that package in the `package.json` that imports it; never switch `linker` to `hoisted` or add to `publicHoistPattern` to work around it. | ||||||
|
|
||||||
| ## Coding Style | ||||||
|
|
||||||
|
|
||||||
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| [tools] | ||
| bun = "1.3.14" | ||
| node = "24.18.0" | ||
| node = "24.18.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word 'instead' at the end of the sentence is redundant. Removing it simplifies the instruction and makes it more direct, adhering to the style guide rule to eliminate redundancy.
References