Fix CI/CD API-key dialog (Settings.Read permission, scroll) and PRTG hint#442
Open
Wiesenwischer wants to merge 1 commit into
Open
Fix CI/CD API-key dialog (Settings.Read permission, scroll) and PRTG hint#442Wiesenwischer wants to merge 1 commit into
Wiesenwischer wants to merge 1 commit into
Conversation
…og scrollable, fix PRTG hint
- CI/CD: the PRTG HTTP status endpoint requires Settings.Read, but the Create API Key dialog
offered only Hooks.* permissions — so the documented PRTG sensor flow could not be completed.
Add a 'Read Status (PRTG)' permission (Settings.Read) to the key creation options.
- CI/CD: the Create/Revoke API key modals had no max-height/scroll, so the dialog header was
clipped on shorter (e.g. 1080p) viewports. Add max-h-[90vh] + overflow + padding so it scrolls.
- SNMP/PRTG: fix the missing space in the sensor instructions ('Settings:Readvia' -> proper
spacing) and point the step at the actual 'Read Status (PRTG)' permission.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three issues spotted on the CI/CD Integration and SNMP/PRTG settings pages.
1. Missing
Settings.Readpermission for the PRTG sensorThe PRTG HTTP status endpoint (
GET /api/integrations/prtg/status) requires[RequirePermission("Settings","Read")], but the Create API Key dialog only offeredHooks.*permissions — so the documented PRTG "HTTP Data Advanced" flow couldn't actually be completed. Added a "Read Status (PRTG)" permission (Settings.Read) to the key options. No backend change needed: the create handler accepts arbitrary permission strings andApiKey.HasPermission/RbacServicealready matchSettings.Read.2. Create API Key dialog clipped at 1080p
The modal had no
max-height/scroll, so on shorter viewports (e.g. full-HD) the "Create API Key" header was cut off at the top with no way to scroll. Addedmax-h-[90vh] overflow-y-autoto the modal andoverflow-y-auto p-4to the backdrop (Create + Revoke modals).3. PRTG sensor instructions text
Settings:Readjargon, so it matches the checkbox a user sees.Testing
pnpm build(tsc + vite): green.Settings.Readverified end-to-end againstApiKey.HasPermission+RbacServiceapi-permission matching (Resource.Action, wildcard-aware).