fix(catalog): show full product version instead of truncating to 8 chars#421
Open
Wiesenwischer wants to merge 1 commit into
Open
fix(catalog): show full product version instead of truncating to 8 chars#421Wiesenwischer wants to merge 1 commit into
Wiesenwischer wants to merge 1 commit into
Conversation
The Stack Catalog product card truncated the version via substring(0, 8), cutting semantic versions like '4.0.0-preview' to '4.0.0-pr'. Show the full version; the badge sits in a flex-wrap container and reflows as needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the Stack Catalog, the product version badge was truncated to 8 characters via
substring(0, 8). Semantic versions longer than that were cut mid-word — e.g.4.0.0-previewdisplayed asv4.0.0-pr.Fix
Render the full
product.version. The badge already lives in aflex-wrapcontainer, so it reflows cleanly instead of clipping.The
substring(0, 8)was likely intended for truncating a git SHA; for SemVer it produced misleading output.Verification
pnpm build(tsc + vite) passes with 0 errorswwwrootassets included