Use urllib.parse.urljoin instead of string concat#26
Open
AdamHepner wants to merge 1 commit into
Open
Conversation
pashidlos
requested changes
Aug 18, 2021
Member
There was a problem hiding this comment.
thanks for contribution @AdamHepner!
there are more places to cover
could you complete them all?
Author
|
I can look into it when I have time, but can't tell when this will be |
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25
This is a quick fix, but I don't know if it breaks anything else, and to be honest I don't have time to check it right now. Hope it helps anyway.