Refactor patch mesh processing - #232
Merged
Merged
Conversation
Add 32-bit reads to the shared bit reader so mesh coordinates retain their full supported width. Preserve mesh-specific EOF and truncation handling while removing the duplicate sample reader. Co-authored-by: Codex <codex@openai.com>
Replace generic string-backed mesh failures with decoder, free-form, and patch-specific thiserror enums exposed through PdfShadingError. Return structured variants at each validation site and update parser regressions to assert exact error categories. Co-authored-by: Codex <codex@openai.com>
Split patch mesh dictionary parsing, packed stream decoding, and geometry-specific continuation reconstruction into focused flat modules. Share the Coons and tensor parser flow through PatchKind and document the internal boundaries. Add regressions for every shared edge mapping. Co-authored-by: Codex <codex@openai.com>
Expose RGBA8 conversion as a Color method so callers can reuse the shared clamping and rounding behavior. Update mesh rasterization to use the method and cover conversion and out-of-range channel handling with focused tests. Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.