Add Grib 41#1574
Merged
Merged
Conversation
lesserwhirls
requested changes
Jun 23, 2026
lesserwhirls
left a comment
Member
There was a problem hiding this comment.
This looks great, and thank you for including a test! The only change I would make is to remove the full grib2 file and only include the GRIB index file. The .gbx9 file contains everything in the GRIB message except the data blocks. In the past, there have been questions about licensing of the data and the ability to redistribute, even for testing purposes.
lesserwhirls
approved these changes
Jun 23, 2026
Member
|
It looks like the code style check started failing with your last change. You can fix this fairly quick by running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR only adds support for the 4.41 Template type. It is basically a copy of the other types, but following the structure doc 4.41: https://www.cosmo-model.org/content/model/cosmo/grib/pdtemplate_4.41.htm
Has been tested on a File provided by MeteoSwiss: ICON CH2 OGD -> Parameter POACsnc (CTRL), e.g., here (may be out of date when reviewing).
Disclosure: The test case has been generated with AI following the structure of the PDS 4.40 test case.
PR Checklist
until ready for review