Skip to content

Add Grib 41#1574

Merged
lesserwhirls merged 2 commits into
Unidata:maint-5.xfrom
SebastianThomas:feature/grib-41
Jun 23, 2026
Merged

Add Grib 41#1574
lesserwhirls merged 2 commits into
Unidata:maint-5.xfrom
SebastianThomas:feature/grib-41

Conversation

@SebastianThomas

@SebastianThomas SebastianThomas commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Description of Changes

This PR only adds support for the 4.41 Template type. It is basically a copy of the other types, but following the structure doc 4.41: https://www.cosmo-model.org/content/model/cosmo/grib/pdtemplate_4.41.htm

Has been tested on a File provided by MeteoSwiss: ICON CH2 OGD -> Parameter POACsnc (CTRL), e.g., here (may be out of date when reviewing).

Disclosure: The test case has been generated with AI following the structure of the PDS 4.40 test case.

PR Checklist

  • Link to any issues that the PR addresses
  • Add labels
  • Open as a draft PR
    until ready for review
  • Make sure GitHub tests pass
  • Mark PR as "Ready for Review"

@lesserwhirls lesserwhirls left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, and thank you for including a test! The only change I would make is to remove the full grib2 file and only include the GRIB index file. The .gbx9 file contains everything in the GRIB message except the data blocks. In the past, there have been questions about licensing of the data and the ability to redistribute, even for testing purposes.

@lesserwhirls lesserwhirls added this to the 5.10.0 milestone Jun 23, 2026
@SebastianThomas SebastianThomas marked this pull request as ready for review June 23, 2026 15:25
@lesserwhirls

Copy link
Copy Markdown
Member

It looks like the code style check started failing with your last change. You can fix this fairly quick by running ./gradlew spotlessApply (it can be a little annoying). I'll go ahead and merge this is and fix the formatting on my next PR. Thank you for the contributions!

@lesserwhirls lesserwhirls merged commit f3130b9 into Unidata:maint-5.x Jun 23, 2026
14 of 15 checks passed
@lesserwhirls lesserwhirls mentioned this pull request Jun 23, 2026
5 tasks
@SebastianThomas SebastianThomas deleted the feature/grib-41 branch June 23, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants