docs: define the failing set_up_before_script contract#842
Merged
Conversation
Documents the behavior pinned in #838: hook failure marks every test in the file as failed, totals stay consistent, the suite continues, and a trailing `cmd && var=value` guard counts as hook failure — with the explicit-success idiom for optional-dependency skips. Claude-Session: https://claude.ai/code/session_01JSeB8UzLCpqst55hAK6dED
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
Related #836
The docs described hook failure as "halts the file immediately" — accurate but incomplete now that #838 defined the full contract.
💡 Changes
set_up_before_scriptfails every test in the file, keeps totals consistent, and never stops the rest of the suitecmd && var=valueguard footgun and the explicit-success idiom for optional-dependency skipshttps://claude.ai/code/session_01JSeB8UzLCpqst55hAK6dED