Fix text cutoff and skill cap stuck past level 75#2
Open
TreeFidyDad wants to merge 3 commits into
Open
Conversation
Increase text_block_h from 52 to 62 pixels in both skill_crystal and skill_donut renderers. The previous value did not leave enough vertical space for three lines of caption text (name, cur/cap, level hint), causing the imgui auto-resize window to clip the bottom text. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The skill_cap_for() function hard-clamped at level 75, so when the engine didn't return a valid cap (GetCap() returning 0/nil) and the player level exceeded 75, the displayed cap froze at the level-75 value. The skill value kept rising but the cap never increased, making it appear capped when it wasn't. Fixes: - Extrapolate cap past level 75 using the end-slope of CAP_REF tables instead of clamping - Extend effective_level_for and min_mob_level_for searches to level 99 - When using fallback table cap (no engine cap) and cur exceeds it, bump cap to cur+1 so skills aren't falsely flagged as capped (handles merit points and server-specific cap adjustments the table doesn't know about) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
TreeFidyDad
changed the title
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
1. Bottom row of text cut off in crystal/donut cards
The
text_block_hwas 52px — not enough vertical space for all 3 caption lines (skill name, cur/cap, level hint). Increased to 62px.2. Skill cap stops updating past level 75
When the engine's
GetCap()returns 0/nil, the fallbackskill_cap_for()was hard-clamped at level 75. This meant:Changes:
skill_cap_for()now extrapolates past level 75 using the end-slope ofCAP_REFtableseffective_level_for/min_mob_level_forsearch up to level 99cur > cap, bump cap tocur + 1so skills aren't falsely flagged as capped