fix: finalization fallback to deploy node when observer unreachable#2
Open
ozerovio wants to merge 3 commits into
Open
fix: finalization fallback to deploy node when observer unreachable#2ozerovio wants to merge 3 commits into
ozerovio wants to merge 3 commits into
Conversation
…chable - standalone has no listener on the observer port (grpc + 1), so the check wrongly reported "did not reach terminal state" - on an observer query error, retry the deploy node's own HTTP port, which also serves /api/deploy-finalization-status - a shard observer responds, so the fallback never runs (behavior unchanged)
Per review: drop the node_http_port != http_port guard (a leaky proxy that skipped the fallback when observer and node shared a port on different hosts) and the upfront allocations. Fall back to the deploy node on any observer error, building the node client lazily. Document the observer HTTP = observer_grpc_port + 1 convention on --observer-port.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Falls back to the deploy node when the observer is unreachable (standalone). Per review: gate on the observer error only + document the observer_grpc_port + 1 convention.