Add missing MAC settings profile ID path fields#7952
Open
halimi wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
References: https://github.com/TheThingsIndustries/lorawan-stack-support/issues/1467
References: https://github.com/TheThingsIndustries/lorawan-stack-support/issues/1477
This fixes a bug when the MAC settings profile config values are not applied to the new MAC state during the join procedure (OTAA) or during the factory reset (ABP).
Changes
Testing
Steps
Results
Create a MAC settings profile with a desired max EIRP value 30
Check that the device's MAC state desired parameters has the max eirp value 30
Response:
Regressions
...
Notes for Reviewers
...
Checklist
README.mdfor the chosen target branch.CHANGELOG.md.CONTRIBUTING.md, there are no fixup commits left.