Harden installer disk target validation and live-media exclusion#29
Open
Copilot wants to merge 2 commits into
Open
Harden installer disk target validation and live-media exclusion#29Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix code issues from review comments
Harden installer disk target validation and live-media exclusion
May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses review feedback on installer safety checks in
scripts/install.sh. It tightens--diskvalidation and makes live-boot detection more precise to prevent destructive operations on invalid or active boot media.Disk argument hardening (
--disk)diskvialsblk -ndo TYPEbefore accepting--disk.Live boot media protection
is_live_boot_disk()to detect currently booted install media.--diskpreselection and reject live medium as install target.Safer live-label matching
ARCHISO,CVH_LINUX_,CODEVERSE_) to avoid excluding unrelated disks.Interactive disk list filtering
get_installable_disks()and use it in disk selection so live media is excluded from presented candidates.User-facing error formatting
" Select a different disk.").