feat: added input validation in installer#26
Open
Ayush4958 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Ayush <bhandariayush935@gmail.com>
Contributor
youngcoder45
left a comment
youngcoder45
left a comment
There was a problem hiding this comment.
tbh looks good to me just want a review from @sinisterMage
| log_warn "Invalid username '$USERNAME'. (Attempt $attempt/$max_attempts)" | ||
| echo -e " ${DIM}Usernames must start with a letter or underscore,${NC}" | ||
| echo -e " ${DIM}and contain only lowercase letters, digits, - or _.${NC}" | ||
| echo |
There was a problem hiding this comment.
Pull request overview
This PR adds additional input validation and safety checks to the interactive installer flow to reduce the risk of destructive actions (e.g., wiping the wrong disk) due to invalid user input.
Changes:
- Adds live-boot medium detection and excludes it from install targets (including
--diskpreselection). - Improves disk selection UX with detailed disk info and a confirmation prompt; adds retry limits for invalid selections.
- Adds retry-limited validation loops for hostname and username prompts.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+107
to
+115
| # Block partitions ,only allow whole disks | ||
| if [[ "$2" =~ [0-9]$ ]] && [[ -n "$(lsblk -dno PKNAME "$2" 2>/dev/null)" ]]; then | ||
| echo -e "${RED}[ERROR]${NC} '$2' appears to be a partition, not a whole disk." | ||
| echo -e " Please specify the parent disk instead (e.g. /dev/sda, /dev/nvme0n1)." | ||
| echo -e " Available disks :-" | ||
| lsblk -dno NAME,SIZE,MODEL | grep -vE "^(loop|sr|rom|fd|zram)" | \ | ||
| awk '{printf " /dev/%-10s %s\n", $1, $2}' | ||
| exit 1 | ||
| fi |
Comment on lines
+118
to
+120
| echo -e "${RED}[ERROR]${NC} '$2' is the live boot medium! You cannot install to it." | ||
| echo -e "-Select a different disk." | ||
| exit 1 |
Comment on lines
+305
to
+307
| # Check if the disk holds the archiso label | ||
| if lsblk -no LABEL "$dev" 2>/dev/null | grep -qiE "(archiso|cvh|codeverse)"; then | ||
| return 0 |
Comment on lines
+107
to
+115
| # Block partitions ,only allow whole disks | ||
| if [[ "$2" =~ [0-9]$ ]] && [[ -n "$(lsblk -dno PKNAME "$2" 2>/dev/null)" ]]; then | ||
| echo -e "${RED}[ERROR]${NC} '$2' appears to be a partition, not a whole disk." | ||
| echo -e " Please specify the parent disk instead (e.g. /dev/sda, /dev/nvme0n1)." | ||
| echo -e " Available disks :-" | ||
| lsblk -dno NAME,SIZE,MODEL | grep -vE "^(loop|sr|rom|fd|zram)" | \ | ||
| awk '{printf " /dev/%-10s %s\n", $1, $2}' | ||
| exit 1 | ||
| fi |
Comment on lines
+118
to
+120
| echo -e "${RED}[ERROR]${NC} '$2' is the live boot medium! You cannot install to it." | ||
| echo -e "-Select a different disk." | ||
| exit 1 |
Comment on lines
+305
to
+307
| # Check if the disk holds the archiso label | ||
| if lsblk -no LABEL "$dev" 2>/dev/null | grep -qiE "(archiso|cvh|codeverse)"; then | ||
| return 0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I had added input validation and safety checks in installation process which will prevent user to enter invalid input during installlation.
Changes
archiso/cvh/codeverse)Related Issue
Fix #16
Checklist