Skip to content

Fix for Gt911Touch#538

Merged
KenVanHoeylandt merged 1 commit into
mainfrom
gt911-fix
Jun 22, 2026
Merged

Fix for Gt911Touch#538
KenVanHoeylandt merged 1 commit into
mainfrom
gt911-fix

Conversation

@KenVanHoeylandt

@KenVanHoeylandt KenVanHoeylandt commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Corrected I2C clock configuration for GT911 touch input on compatible ESP32 devices, ensuring proper timing based on the detected driver variant.

@KenVanHoeylandt KenVanHoeylandt merged commit e50659a into main Jun 22, 2026
0 of 9 checks passed
@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 44b123ad-9764-4cd0-8d9d-2b730522ffc6

📥 Commits

Reviewing files that changed from the base of the PR and between aeccc15 and 9c19ddc.

📒 Files selected for processing (1)
  • Drivers/GT911/Source/Gt911Touch.cpp

📝 Walkthrough

Walkthrough

In Gt911Touch::createIoHandle, the assignment of io_config.scl_speed_hz is relocated from a common initialization block (which ran regardless of I2C driver variant) into the code path specific to the espressif,esp32-i2c-master driver, just before the V2 panel IO handle is created. As a result, the SCL speed is now only configured when that particular driver is selected; the other driver path no longer sets this field.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch gt911-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@KenVanHoeylandt KenVanHoeylandt deleted the gt911-fix branch June 22, 2026 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant