Driver improvements & fixes#535
Merged
Merged
Conversation
|
Important Review skippedToo many files! This PR contains 222 files, which is 72 over the limit of 150. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (222)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
+ updated existing drivers that didn't have the slot attribute defined in their DTS
Crazypedia
added a commit
to Crazypedia/Tactility-lilygo-tdeck-max
that referenced
this pull request
Jun 28, 2026
…node Replaces the deprecated SpiSdCardDevice (removed upstream in TactilityProject#535) with a declarative sdcard@1 node under spi0: - spi0 now lists all chip-selects via cs-gpios (display=34, sd=48, radio=3); the SPI driver drives them high on start, so the bus deselects every peripheral before any one transacts -- replacing our manual csPinWorkAround. - The SD card resolves its own CS from cs-gpios[1] by node address. - status="disabled": the node is constructed/added but not auto-started; Hal::init's mountAll() starts it before displays come up (SPI displays must start after the SD card is mounted on the shared bus). Deletes devices/Sdcard.cpp/.h and the createSdCard() call. Devicetree compiler validated: sdcard registers as DTS_DEVICE_STATUS_DISABLED with frequency 20000. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cs-pinsand set them to high on driver startfile_system_set_owner()andfile_system_get_owner()FileSystemis part of a shared SPI busdevice_get_child_count()slotvalue