Skip to content

Move Host Layer to Alpine#225

Open
TrentTAMU wants to merge 1 commit into
mainfrom
move-host-layer-to-alpine
Open

Move Host Layer to Alpine#225
TrentTAMU wants to merge 1 commit into
mainfrom
move-host-layer-to-alpine

Conversation

@TrentTAMU

Copy link
Copy Markdown

Description

Moved from Ubuntu host layer image to Alpine in order to produce a smaller image.

Removed USER_ID and GROUP_ID settings since the deployment should be using k8s Secrets mounted to the filesystem instead of mounting NFS just for configs.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Ran the new image in Dev and tested by navigating to https://labs.library.tamu.edu/mylibrary and testing the responses from the CatalogService.

Source code/libraries have not been changed, so regression testing should not be necessary.

Test Configuration:

  • Toolchain:
  • SDK: 11-jdk-noble

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

<I'll get back to filling this out at some point, the issue is not urgent at all>

Moved from Ubuntu host layer image to Alpine in order to produce a smaller image.

Removed USER_ID and GROUP_ID settings since the deployment should be using k8s Secrets mounted to the filesystem instead of mounting NFS just for configs.
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 29101840480

Coverage remained the same at 63.032%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 1339
Covered Lines: 844
Line Coverage: 63.03%
Coverage Strength: 0.63 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants