fix: solution import no longer hides build errors or imports stale zips - #179
Open
zekelinAlex wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When import builds a Build SDK project it relogged every build output line as
[INFO], so packager errors like "RootComponent validation failed" were
invisible. Then it just grabbed the newest zip from bin, which could easily be
a leftover from an older build.
Build output lines are now classified, errors log as errors, and the import
stops when the build reports errors even with exit code 0 (older SDK versions
do exactly that). Only a zip written by the current build is accepted.
Also stopped hardcoding bin/{config}/net462: the current Build SDK outputs to
net472, so the zip is now searched anywhere under bin/{config}.
Closes #178.