fix: fresh headers per paged request, cap SQL results at TOP (#172) - #175
Open
zekelinAlex wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ServiceClient.ExecuteWebRequestmutates the header dictionary it receives by adding aCookieentry. We passed the same dictionary to every paged request, so fetching any@odata.nextLinkpage failed with "An item with the same key has already been added. Key: Cookie". Each request now gets a fresh dictionary, inDataverseQueryServiceand inSolutionComponentQueryReader.The
?sql=endpoint turnsTOP ninto a page size, not a row limit, soSELECT TOP 5on a bigger table returned five rows plus a nextLink and hit the crash above. Following the links would also download the whole table in pages of five, so the client now readsTOPfrom the query and stops at that many rows; with--top, the smaller limit wins.The FROM parser also accepts
dbo.accountand bracketed names like[account]now. The endpoint always took these, we just failed to extract the table name from them.Close #172