Skip to content

Enforce TypeScript strict mode and eliminate all implicit any types #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kingsman-99 merged 2 commits into from
Jun 30, 2026
Merged

Enforce TypeScript strict mode and eliminate all implicit any types #410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
565a89a
Enforce TypeScript strict mode and eliminate all implicit any types
MJigah Jun 29, 2026
7eff8a0
Merge branch 'main' into feature/enforce-type-checks
Kingsman-99 Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ jobs:
- name: Run tests
run: npm test

- name: Type check (strict)
run: npx --no-install tsc --noEmit

- name: Publish
run: npm publish --provenance --access public
env:
Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,13 @@ All notable changes to this project will be documented in this file.

## Unreleased

### Chores

- Upgrade SDK to TypeScript strict mode (`strict`, `noImplicitAny`, `strictNullChecks`, `strictFunctionTypes`) and enable `noUncheckedIndexedAccess` for safer type-checking for SDK consumers.

### Features


- **Build invoice diff utility — compare two invoice states (closes #363)**
- `diffInvoices(a: Invoice, b: Invoice)` returns structured diff of two invoice objects
- Returns `InvoiceDiff` as `{ field: string, before: unknown, after: unknown }[]` — only changed fields listed
Expand Down
7 changes: 7 additions & 0 deletions TODO.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
- [ ] Replace all remaining `as any` casts with proper types/type guards across `src/`
- [ ] Confirm `./node_modules/.bin/tsc --noEmit` passes with strict + noUncheckedIndexedAccess
- [x] Add changelog entry for strict-mode upgrade for SDK consumers

- [ ] Add CI type-check step to ALL build workflows (not just publish)
- [ ] Ensure no function parameters/return types are implicitly `any` (verify with `tsc --noEmit`)

Loading
Loading