Add focused parser state-transition tests#78
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds targeted, parser-focused tests in embedding/parsing to make state-machine regressions easier to pinpoint, complementing the existing end-to-end embedding coverage and addressing the need from issue #63 for explicit state-transition and malformed EOF/fence cases.
Changes:
- Added direct state-transition specs covering multiline instruction consumption, code fence open/close transitions, and end-state embedding rendering.
- Added focused malformed-EOF coverage ensuring unclosed
<embed-code>tags produce a typedInstructionParseErrorwith the correct start line and reason.
Oleg-Melnik
approved these changes
Jul 2, 2026
MykytaPimonovTD
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds own-package tests for parser states in
embedding/parsing.Resolves this issue.