-
Notifications
You must be signed in to change notification settings - Fork 0
Provide resolver cache configuration #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
cc1026d
Make resolver cache configurable.
Vladyslav-Kuksiuk c27cd9b
Add tests.
Vladyslav-Kuksiuk 9ca5f04
Merge remote-tracking branch 'refs/remotes/origin/master' into improv…
Vladyslav-Kuksiuk 0dbf946
Remove unused resolver provisioning.
Vladyslav-Kuksiuk 567501b
Improve doc.
Vladyslav-Kuksiuk c2ce65d
Improve error behavior.
Vladyslav-Kuksiuk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,8 +31,9 @@ import ( | |
| _type "embed-code/embed-code-go/type" | ||
| ) | ||
|
|
||
| // resolverCacheLimit is the maximum number of source files retained in the resolver cache. | ||
| const resolverCacheLimit = 100 | ||
| // DefaultResolverCacheLimit is the default maximum number of source files | ||
| // retained in a resolver cache. | ||
| const DefaultResolverCacheLimit = 100 | ||
|
|
||
| // fragmentedFile stores cleaned source lines and parsed fragments for one source file. | ||
| type fragmentedFile struct { | ||
|
|
@@ -53,13 +54,24 @@ type Resolver struct { | |
| } | ||
|
|
||
| // NewResolver creates a resolver with an independent source-fragment cache. | ||
| func NewResolver() *Resolver { | ||
| // | ||
| // Parameters: | ||
| // cacheLimit - maximum number of source files retained in the resolver cache. | ||
| // | ||
| // Returns: | ||
| // *Resolver - resolver with an independent cache. | ||
| // error - when cacheLimit is below one. | ||
| func NewResolver(cacheLimit int) (*Resolver, error) { | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is the whole PR intention, to have it configurable. |
||
| if cacheLimit < 1 { | ||
| return nil, errors.New("resolver cache limit must be at least 1") | ||
| } | ||
|
|
||
| return &Resolver{ | ||
| cache: newCache[absolutePath, fragmentedFile]( | ||
| resolverCacheLimit, | ||
| cacheLimit, | ||
| loadSourceFragments, | ||
| ), | ||
| } | ||
| }, nil | ||
| } | ||
|
|
||
| // ResolveContent returns source lines for the requested code file fragment. | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This cache limit is not intended to be configured by the user, for now.