Accept extra.set(...) in version parsers; bump Compiler; tidy imports#723
Merged
Conversation
Update `fallbackVersion` and `fallbackDfVersion` in `Compiler` from `2.0.0-SNAPSHOT.057` to `2.0.0-SNAPSHOT.059`.
Companion to the `agents` change that migrates `version.gradle.kts` off Gradle's
deprecated `by extra(...)` property delegate. Teach the config repo's version
tooling to read and write the new `extra.set("name", value)` form while still
accepting the legacy `by extra(...)` spelling, so the transition is safe for
lazily-migrated repos (a migrating branch is compared against an old-form base).
- buildSrc `VersionGradleFile`: add `extra.set` literal/alias regexes to the CI
Version Guard parser; KDoc documents both spellings, with tests for the new
literal and alias forms.
- scripts/publish-documentation/publish.sh: emit `extra.set(...)` when stamping
the Dokka publishing version.
- scripts/revalidate-versions.sh: `parse_version()` reads both spellings.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the config repo’s version tooling to recognize Gradle’s newer extra.set("key", …) form (while keeping legacy by extra(...) compatibility), bumps the Spine Compiler fallback snapshot versions, and tidies a couple of redundant imports.
Changes:
- Extend
VersionGradleFileparsing (and tests) to support bothextra.set(...)and legacyby extra(...)declarations, including one-hop alias resolution. - Update documentation publishing and version revalidation scripts to emit/parse
extra.set(...). - Bump
Compilerfallback versions from2.0.0-SNAPSHOT.057to2.0.0-SNAPSHOT.059and remove redundant self-imports.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/revalidate-versions.sh | Teach parse_version() to read extra.set(...) literals/aliases while retaining legacy parsing. |
| scripts/publish-documentation/publish.sh | Emit extra.set("versionToPublish", "...") when stamping Dokka publishing version; update copyright year. |
| buildSrc/src/test/kotlin/io/spine/gradle/VersionGradleFileSpec.kt | Add coverage for extra.set(...) literal and alias cases. |
| buildSrc/src/main/kotlin/io/spine/gradle/VersionGradleFile.kt | Add extra.set(...) regex support and integrate it into parse() alongside legacy regexes. |
| buildSrc/src/main/kotlin/io/spine/dependency/local/Compiler.kt | Bump fallback Compiler versions to .059 and remove redundant imports. |
armiol
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a
misc-fixesbranch bundling three commits.1. Accept
extra.set(...)in the version tooling — companion to SpineEventEngine/agents#29Gradle deprecated the
by extra(...)property delegate used inversion.gradle.kts.The
agentsPR extends thebump-versionskill to migrate declarations toextra.set("name", value); this PR teaches the config repo's version tooling toread/write the new form while still accepting the legacy spelling, so the transition
is safe for lazily-migrated repos (a migrating branch is compared against an
old-form base).
buildSrc/.../VersionGradleFile.kt— the CI Version Guard parser: addextra.setliteral/alias regexes, fold them intoparse(), and document bothspellings in the KDoc. Two new spec cases cover the literal and alias forms.
scripts/publish-documentation/publish.sh— emitextra.set(...)when stampingthe Dokka publishing version (copyright header bumped to 2026).
scripts/revalidate-versions.sh—parse_version()reads both spellings.Merge ordering: land this before any repo migrates its
version.gradle.kts,so the Version Guard recognizes the new form. Both sides are backward-compatible, so
beyond that, order doesn't matter.
2. Bump Compiler fallback versions to
2.0.0-SNAPSHOT.059Updates
fallbackVersionandfallbackDfVersioninCompilerfrom.057to.059. (The commit message was corrected from an earlier inaccurate"Remove redundant imports" — the diff was always this version bump.)
3. Remove redundant imports
Drops two redundant private property imports in
Compiler.kt.The imports were accidentally (and forcibly) added by IntelliJ IDEA.
Verification
./gradlew -p buildSrc build→ BUILD SUCCESSFUL (compiles +VersionGradleFileSpecpasses). Reviewed by
spine-code-review,kotlin-engineer(both APPROVE),review-docs(APPROVE WITH CHANGES — minor KDoc-wording nits), anddependency-audit(the Compiler bump is a clean forward bump — no rollback/BOM mismatch). Version gate
not applicable (config has no root
version.gradle.kts).🤖 Generated with Claude Code