BED-8693: Complete data collection regardless of single object errors#17
Open
StranDutton wants to merge 1 commit into
Open
BED-8693: Complete data collection regardless of single object errors#17StranDutton wants to merge 1 commit into
StranDutton wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds try/except error handling to all resource and transformer functions in the OpenHound GitHub extension so that a failure on a single object (org, repo, team, etc.) doesn't abort the entire collection.
summary of changes:
organization.py: Wrapped 40 resource/transformer functions with per-object error handlingenterprise.py: Wrapped 11 resource/transformer functions with per-object error handlingLog format follows the existing
safe_resource_wrapperconventionThe
extrabit in the error log messaging is included because they get emitted as top-level keys in JSON logs. It's only useful for log aggregation in BHE service deployments (they're not visible in CLI mode)Complementary to PR #32 which handles schema/data-type failures. This PR handles API/network failures, but both apply to the same ticket
Validation: Successfully ran a collection to SpecterOps GitHub org