feat: make max_attempts a sliding window, not a lifetime cap#6
Merged
Conversation
state.attempts was a lifetime counter that only reset on manual switch or reset, so a few early transient blips could disable fallback for the rest of a long-running session. Fallback attempts are now timestamped and counted within a sliding window (`attempts_window_ms`, default 10 min). Once the window passes, older attempts no longer count against `max_attempts`. Set `attempts_window_ms: 0` to restore the previous absolute lifetime limit. status now also reports `windowAttempts` and `attemptsWindowMs`. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Проблема
state.attempts— пожизненный счётчик, сбрасывался только при ручном switch/reset. Несколько ранних блипов rate-limit → fallback отключён до конца длинной сессии.Решение
Попытки fallback теперь метятся временем и считаются в скользящем окне
attempts_window_ms(по умолчанию 10 минут). По прошествии окна старые попытки перестают учитываться вmax_attempts.attempts_window_ms: 0возвращает прежний абсолютный лимит на всю сессию.statusдополнительно отдаётwindowAttemptsиattemptsWindowMs.reset, ручной switch, recovery) чистят и таймстемпы через общийclearAttempts.Тесты
attempts_window_ms: 0→ лимит остаётся абсолютным.Юнит-тесты 49/49, typecheck чист.
🤖 Generated with Claude Code