Ajout de l'économie développeur (les Bits) - #1362
Open
iambibi wants to merge 12 commits into
Open
Conversation
…teme de lien entre les joueurs et les contributeurs
iambibi
added
📦 Feature
# Conflicts: # src/main/java/fr/openmc/core/features/economy/EconomyManager.java
iambibi
marked this pull request as ready for review
July 25, 2026 14:09
Member
Author
|
a review |
Member
|
Attention conflits |
Member
Author
|
oui je fais les conflits sur mes pr la (un peu con j'ai pas fait mes branches avec la derniere version des commits ptdr) |
AxenoDev
reviewed
Jul 27, 2026
AxenoDev
left a comment
AxenoDev
left a comment
Member
There was a problem hiding this comment.
je fini de review un peu plus tard
# Conflicts: # src/main/java/fr/openmc/core/features/events/contents/dailyevents/DailyEventsManager.java # src/main/java/fr/openmc/core/registry/items/CustomItemRegistry.java # src/main/java/fr/openmc/core/registry/loottable/CustomLootTableRegistry.java
Member
Author
et moi jpp un peu plus tard, je dois partir dans une heure. sinon on reporte la feature pour la 2.5.0-beta-3, mais bon... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Petit résumé de la PR
j'ai fait un GithubHook qui pour moi ça simplifier les relations qu'on a avec l'api de github.
Meme si je pense que je pourrais faire mieux en utilisant du GSON (que la lib bizzare que miseur a utilisé), tt les objects json je les passe en classe mais bon je prefere pas m'attarder dessus.
j'en ai profité pour commencer un mini nettoyage dans la classe leaderboardmanager
PS : j'ai pas d'acces visuel à la DB, donc cette feature va être testé avec de la logique et de la théorie ahaa
Étape nécessaire afin que la PR soit fini (si PR en draft)
Decrivez vos changements