Resolve server-side spec gaps#116
Draft
maximmaxim345 wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR with server-implementation-breaking changes I mentioned in #113. Clients do not have to adjust anything for these; they tighten what a conforming server must do.
Specifically:
supported_roles.payloadfields, and MUST NOT send fields the spec does not define.stream/request-format: a request the server cannot honor is not an error; the stream continues in a configuration the client supports. For players,stream/startMUST use a format from the client'ssupported_formats, so the server can never start a stream the client cannot decode.stream/start(initial or post-reconnect), the server SHOULD immediately send the current image for each channel whosesourceis not'none', so a client joining mid-track is not left blank until the next track change.Draft
This PR is still marked as draft since it depends on:
stateto a booleanavailable#115