-
Notifications
You must be signed in to change notification settings - Fork 223
Add GLM-5.1 NVFP4 GB300 disaggregated dynamo-sglang MTP config / 添加 GLM-5.1 NVFP4 GB300 分离式 dynamo-sglang MTP 配置 #2114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RohitNagraj
wants to merge
7
commits into
main
Choose a base branch
from
glm5-fp4-gb300-dynamo-sglang-mtp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+305
−10
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
cfff85f
Add glm5-fp4-gb300-dynamo-sglang-mtp config
RohitNagraj 58225d0
Update perf-changelog pr-link for #2114
RohitNagraj 189b328
Strip zip_override selector before name-override sed in launch_gb300-…
RohitNagraj 680458b
Point gb300 MTP config at GLM-5.1 NVFP4 weights
RohitNagraj 3abca82
Use glm5.1 model-prefix for gb300 MTP config (match PR #1780 convention)
RohitNagraj de6750f
Merge remote-tracking branch 'origin/main' into glm5-fp4-gb300-dynamo…
RohitNagraj 929cd38
Skip srtctl preflight for gb300 glm5.1 (weights on compute-only /scra…
RohitNagraj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 The PR title and description are English-only, but AGENTS.md line 7 requires bilingual PR titles (
<English> / <中文>) and a## 中文说明section in the body mirroring the summary. Nit — pure documentation/process issue, no functional impact. Consider updating the title to something likeAdd GLM-5 NVFP4 GB300 disaggregated dynamo-sglang MTP config / 添加 GLM-5 NVFP4 GB300 分离式 dynamo-sglang MTP 配置and appending a## 中文说明block.Extended reasoning...
What the rule says. AGENTS.md line 7 states: "PR and GitHub-issue titles & descriptions must be bilingual — include a Simplified Chinese version in addition to English. Title format:
<English title> / <中文标题>. In the PR/issue body, follow the English content with its Chinese translation (e.g. a## 中文说明section mirroring the summary...)."\n\nWhat this PR has. The PR title isAdd GLM-5 NVFP4 GB300 disaggregated dynamo-sglang MTP config— English only, no/ <中文>suffix. The body is English-only bullets describing the config, image, and changelog entry; there is no## 中文说明section (or any Chinese content) mirroring the summary.\n\nHow this manifests. This is purely a process/documentation violation. The recipe itself (glm5-fp4-gb300-dynamo-sglang-mtp), thev0.5.13.post1container alias inrunners/launch_gb300-nv.sh, and theperf-changelog.yamlentry are all correctly wired — there is no runtime, build, CI, or sweep impact. It's a review/discoverability concern only.\n\nEnforcement precedent. Recent recipe-add PRs merged tomaindemonstrate the convention is real and achievable: #2107 (Minimax-M3-MXFP8 Eagle3 backend override) carries... /Minimax-M3-MXFP8 Eagle3草稿模型的注意力后端固定为 TRITON_ATTN以提高性能and #2101 (gpt-oss-120b deprecation) carries... / 弃用 gpt-oss-120b 基准测试配置. Enforcement is not perfectly uniform (e.g. #2110, #2100 lack the Chinese half), but the rule is on the books and neighboring PRs of the same shape follow it.\n\nStep-by-step proof.\n\n1. ReadAGENTS.mdline 7 → rule: title format<English> / <中文>, body needs## 中文说明section.\n2. Read PR #2114 title from<pr-metadata>:Add GLM-5 NVFP4 GB300 disaggregated dynamo-sglang MTP config→ no/separator, no Chinese characters (scanning for CJK returns no matches).\n3. Read PR #2114 body → four bullets in English describing the config, image, and changelog entry. Search body for中文说明or any CJK character → none present.\n4. Compare againstgit logentries for #2107 and #2101 — both have Chinese titles → rule is actively followed by peers.\n5. Conclusion: title and body both violate AGENTS.md §Bilingualism convention.\n\nHow to fix. Two edits, both to PR metadata (no code changes):\n\n- Rename the PR title to append a Chinese translation, e.g.:Add GLM-5 NVFP4 GB300 disaggregated dynamo-sglang MTP config / 添加 GLM-5 NVFP4 GB300 分离式 dynamo-sglang MTP 配置.\n- Append a## 中文说明section to the PR body that mirrors the English summary (glm5-fp4-gb300-dynamo-sglang-mtprecipe, ISL/OSL 8k1k+1k1k coverage, high-throughput wide-EP + low-latency TP=4 decode topologies,v0.5.13.post1container alias inlaunch_gb300-nv.sh, imagelmsysorg/sglang:v0.5.13.post1-cu130, and the perf-changelog entry).\n\nNo files in this diff need to change.