fix(api): support agentic-only runs in unofficial-run previews / 修复 agentic 专属 run 的非官方预览#537
Merged
Merged
Conversation
Agentic-only sweeps never run the collect-results merge job (run-sweep.yml only triggers it for fixed-seq sweeps), so they upload per-config bmk_agentic_<config> artifacts with no merged results_bmk. The /api/unofficial-run route only looked for results_bmk and returned 404, breaking ?unofficialrun= chart overlays for agentic PRs. Fall back to downloading every per-config bmk_* artifact (deduped by name, newest id wins) when results_bmk is absent. The fallback stays off when the merged artifact exists since it already contains all per-config rows. Downloads run in bounded batches of 8 to stay clear of GitHub secondary rate limits. 中文:agentic 专属 sweep 不会触发 collect-results 合并任务(run-sweep.yml 仅为固定序列 sweep 触发),因此只上传按配置拆分的 bmk_agentic_<config> 产物,没有合并的 results_bmk。/api/unofficial-run 路由此前只查找 results_bmk 并返回 404,导致 agentic PR 的 ?unofficialrun= 图表叠加预览 失效。现在当 results_bmk 缺失时回退为逐个下载 bmk_* 产物(按名称去重, 保留最新 id),合并产物存在时不启用回退以避免重复计数;下载以每批 8 个 的有界批次执行,避免触发 GitHub 二级速率限制。 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
adibarra
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?unofficialrun=<run-id>chart overlay previews returned 404 for agentic-only sweeps. Root cause: the benchmark repo'srun-sweep.ymlonly triggers thecollect-resultsmerge job for fixed-seq (1k1k / 8k1k) sweeps, so agentic-only runs upload per-configbmk_agentic_<config>artifacts and never produce the mergedresults_bmkartifact that/api/unofficial-runexclusively looked for.results_bmkis absent, the route now falls back to downloading every per-configbmk_*artifact (same-name re-uploads deduped, newest artifact id wins) and normalizes their rows through the existingmapBenchmarkRowpath — which already handles agentic v2-flat/v3-nested agg schemas.results_bmkexists: the merge job downloads thebmk_*pattern, so the merged artifact already contains every per-config row and fetching both would double-count.bmk_*fallback.No frontend changes were needed — the overlay pipeline (
buildChartData→transformBenchmarkRows→applyAgenticMetricAliases,processOverlayChartDatawithisAgentic, legend/points-dialog/dismiss paths) already supports agentic rows; it just never received any.Overlay support
This IS the overlay path — verified manually against a real agentic run from InferenceX PR #2109: loaded
/inference?unofficialrun=28861274175(DSv4 FP4 MI355X vLLM agentic sweep, kvnone + LMCache offload variants) on a local dev server and confirmed:amd/agentx_dsv4_vllm) with working dismissTest plan
bmk_*fallback (agentic rows, correct conc mapping, siblingagentic_*/server_logs_*blobs NOT downloaded), fallback disabled whenresults_bmkexists, same-name dedupe keeps newest artifactpnpm test:unit— 2539 app + 25 mcp tests passpnpm typecheck,pnpm lint,pnpm fmtclean中文说明
?unofficialrun=<run-id>图表叠加预览对 agentic 专属 sweep 一直返回 404。根本原因:基准测试仓库的run-sweep.yml仅在固定序列(1k1k / 8k1k)sweep 时触发collect-results合并任务,因此 agentic 专属 run 只上传按配置拆分的bmk_agentic_<config>产物,从不生成/api/unofficial-run唯一查找的合并产物results_bmk。results_bmk缺失时,路由现在回退为下载所有按配置拆分的bmk_*产物(同名重复上传按最新 id 去重),并通过现有的mapBenchmarkRow路径归一化(该路径已支持 agentic v2 扁平 / v3 嵌套 agg schema)。results_bmk存在时不启用回退:合并任务本身就下载bmk_*模式,合并产物已包含全部按配置行,两者都取会重复计数。已用 InferenceX PR #2109 的真实 agentic run(28861274175,DSv4 FP4 MI355X vLLM)在本地手动验证:NON-OFFICIAL 横幅、模型自动切换、Agentic Traces 场景、5 个叠加点在 Interactivity 与 E2E Latency 图表上均正确渲染,图例开关与数据点弹窗数值与原始产物一致。单元测试(2539 + 25)、typecheck、lint、fmt 全部通过。
🤖 Generated with Claude Code
Note
Medium Risk
Adds many parallel GitHub artifact downloads and changes benchmark resolution for a live API path, but behavior is gated on missing
results_bmkand covered by new tests.Overview
Fixes 404 on
?unofficialrun=for agentic-only CI sweeps that never upload mergedresults_bmk.When
results_bmkis missing,/api/unofficial-runnow collectsbmk_*per-config artifacts (deduped by name, highest artifact id wins), downloads them in batches of 8, and normalizes rows through the existing mapper. The fallback is skipped ifresults_bmkis present to avoid double-counting. Non-bmk_*siblings (e.g.agentic_*trace blobs) are not fetched.404 copy now mentions the per-config fallback. Three route tests cover fallback behavior, merged-artifact precedence, and dedupe.
Reviewed by Cursor Bugbot for commit 274fc59. Bugbot is set up for automated code reviews on this repo. Configure here.