deps: bump undici to 7.28.0 to fix Dependabot alerts#301
Merged
Conversation
Pin jsdom's transitive undici to 7.28.0 via resolutions in the Angular token-refresh and login-pkce samples. Resolves 12 Dependabot alerts (high/medium/low) where undici@7.25.0 was vulnerable. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ksroda-sa
requested review from
bwereszczak,
ikawalec,
jdabrowski and
plandzwojczak-sa
There was a problem hiding this comment.
Pull request overview
This PR aims to resolve Dependabot alerts by forcing the jsdom transitive dependency undici to use 7.28.0 (patched) in the two Angular samples, and updating the corresponding Yarn lockfiles.
Changes:
- Added a scoped Yarn
resolutionsoverridejsdom/undici: 7.28.0in both Angular samplepackage.jsonfiles. - Updated both sample
yarn.lockfiles to includeundici@npm:7.28.0and remove the previously-lockedundici@npm:^7.25.0entry.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| samples/angular/token-refresh/package.json | Adds jsdom/undici scoped resolution to force patched undici version. |
| samples/angular/token-refresh/yarn.lock | Updates undici lock entry to 7.28.0. |
| samples/angular/login-pkce/package.json | Adds jsdom/undici scoped resolution to force patched undici version. |
| samples/angular/login-pkce/yarn.lock | Updates undici lock entry to 7.28.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ikawalec
approved these changes
Jul 9, 2026
bwereszczak
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves all 12 open Dependabot alerts, which were all the same package: undici locked at the vulnerable
7.25.0in two Angular samples, pulled in transitively byjsdom@29.1.1.Added a scoped resolution
"jsdom/undici": "7.28.0"topackage.jsonin bothtoken-refreshandlogin-pkce(matching the existing scoped-resolution style, leaving node-gyp's out-of-rangeundici@6.27.0untouched), then refreshed both lockfiles.Alerts fixed
undici7.28.0 is the first patched version for all 12 alerts (high/medium/low), including:Scope note
These alerts affect only test/dev tooling (
jsdom→ vitest), not the shipped sample apps.🤖 Generated with Claude Code