fix(tooling): generate:check no longer leaves the spec snapshot dirty#15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
bin/generate.mjsalways rewritesspecs/openapi.jsonfrom the live spec (the drift baseline).generate:check(run by the lefthook pre-pushopenapi-drift-checkhook) onlygit diff --exit-codessrc/Generated/blocks/generated, never the snapshot. So when the live spec drifts (e.g. a description update) without a release since, every generate leavesspecs/openapi.jsonmodified silently. A dirty tree then blocksgit checkout, which aborted a post-merge branch switch.Fix
generate:checkrestoresspecs/openapi.jsonafter regenerating, before gating on the generated code. The snapshot is still updated intentionally bynpm run generateand reconciled at release; the generated-code drift gate is unchanged. The working tree stays clean after a check/push.Verified: dirtied the snapshot, ran
generate:check, snapshot restored clean while the generated-code gate still ran (exit 0).