fix(admin): accept pk/sk prefixed API keys in key validation#14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The settings key-format guard only matched the legacy unprefixed key shape, so it rejected the newer prefixed keys the API now issues with the notice "API key format is invalid. Get a key at roxyapi.com." A customer hit this when pasting an active
sk_live_key whose dashboard showed it as valid.Fix
Extend the regex in
SettingsFields::sanitize_encrypted_key()with an optional{pk|sk}_{live|test}_prefix group, mirroring the API key shapes. Legacy unprefixed keys keep validating. Unknown prefixes (rk_, unknown environment, prefix with no body) stay rejected.Verification
wp eval:SettingsFields::sanitize()stores and round-trips legacy, sk_live, pk_live, sk_test; rejects garbage, rk_, bad-env with theinvalid_api_keynotice.sk_live_key saves with no format error and the page reports connected.Clientagainst production returns a valid reading.test-settings-fields-sanitize.php(accept + reject data providers).