Add support for retrieving raw file content from GitLab#124
Merged
Tobias-Fischer merged 6 commits intoJul 4, 2026
Conversation
Contributor
Author
|
I'm also wondering how to support packages not on The latter could use |
traversaro
approved these changes
Jul 3, 2026
Contributor
Author
|
Unrelated test failure? |
Refactor GitHub formatting code and add GitLab formatter.
Return either cached version or attempt download and return result.
0fa52f4 to
430ee3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per title.
I had a couple packages which were hosted on
gitlab.combut were not released / did not have a release repository ongithub.com.Adding them to
rosdistro_additional_recipes.yamlworks fine, but when Vinca tried to download their manifests it ran into this line and refused.GitLab raw URLs are relatively simple, and c6092b4 adds a formatter for them. Follow-up commits then use it when needed.
Checking for host substrings in URLs is a bit brittle, but I did not want to diverge from the existing pattern too much.
The GitHub download path should not be affected by the refactor, it's mostly just shuffling existing code around.