Fix crash when moving a zero-length range#307
Open
sarathfrancis90 wants to merge 1 commit into
Open
Conversation
move(start, end, index) threw a TypeError ('Cannot read properties of
undefined') when start === end, because byEnd[end] is undefined for an
empty range so reading last.next failed. remove() already treats a
zero-length range as a no-op; do the same in move().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
move()crashes with an opaqueTypeError: Cannot read properties of undefined (reading 'next')when called with a zero-length range (start === end):The reason is that for an empty range
byEnd[end]has no chunk, solastisundefinedand the subsequentlast.nextblows up.remove()already short-circuits a zero-length range as a no-op (if (start === end) return this;), so I did the same inmove()— moving nothing has no effect.I found this while fuzzing random valid operation sequences. Added a test alongside the other
moveedge cases; full suite passes.