Improve get_tensor_hash function performance and flexibility - #1
Open
repodex-app[bot] wants to merge 1 commit into
Open
Improve get_tensor_hash function performance and flexibility#1repodex-app[bot] wants to merge 1 commit into
repodex-app[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pull request, we have made changes to the
get_tensor_hash()function to improve its performance and make it more flexible for different use cases. The following changes have been made:np.prod(tensor.shape)withtensor.sizefor better performance, astensor.sizedirectly provides the product of the tensor's shape.np.float16, as this may not be necessary for all use cases and can limit the function's applicability.Here is the updated code:
Please review the changes and let me know if you have any questions or suggestions.