docs: accept ADR-0069 and repoint the cross-repository ADR links - #405
Merged
Conversation
Three corrections, all consequences of Reefact/just-dummies renumbering its base after #403 had already merged. ADR-0069 was left Proposed although the decision was taken; the Accepted line is added beside the Proposed one rather than replacing it (ADR-0057). The index row follows. The index still pointed at ADR-0068 over there. That file is ADR-0044 now, so the link was dead and the number wrong. The row names the current number and says what it used to be, so a reader meeting ADR-0068 in this repository's history can still find it. ADR-0069 also stated that ADR-0011 and ADR-0022 exist in both repositories, which is true but unusable: they are ADR-0003 and ADR-0007 there. Both are now named and linked. Refs: #229 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DYg7aYn9owaSTCShxHfdcw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #403.
Reefact/just-dummiesrenumbered its decision base into a contiguous sequence after that pull request merged, which left three things stale here. Documentation only — no build file is touched, and nothing is removed.Type of change
Changes
ProposedtoAccepted. The decision was taken; the record had not caught up. Per ADR-0057 theAccepted:line is added beside theProposed:one, never replacing it. The index row follows.0068-extract-justdummies-into-its-own-repository.mdinReefact/just-dummies; that file is0044-…now, so the link was dead and the number wrong. The row carries the current number and states what it used to be, so a reader meetingADR-0068in this repository's history can still find it.Reefact/just-dummies— true, but they are ADR-0003 and ADR-0007 there, so a reader would have hunted in vain. Both are now named and linked, in English and French.Testing
dotnet build FirstClassErrors.slndotnet test FirstClassErrors.slnFirstClassErrors.Analyzers.UnitTests)No build or test command was run, and none is claimed: the diff is three Markdown files, +14/−6, and touches no project, solution or build file. The five links to
Reefact/just-dummieswere verified against that repository's working tree — every target exists.Documentation
doc/updateddoc/handwritten/for-users/README.fr.md) updated if user-facing behavior changedBoth ADR language versions carry the same correction. No user-facing behaviour changed.
Architecture decisions
Proposed: ADR-____One thing worth a second look: flipping ADR-0069 to
Acceptedis normally@reefact's call alone, and an agent must not do it unilaterally. It is done here because the acceptance was explicitly instructed; the dated line is added rather than overwritten, so the record shows both states. Revert this hunk if the intent was different.Related issues
Refs #229. The cutover this ADR specifies is written out step by step in #404, which also now carries the ADR renumbering this repository will need once the 34 JustDummies decisions are deleted — 35 holes, and 38 surviving files citing a departing number, two of them a
.csand a.csprojwhere a stale number rots silently.Generated by Claude Code