Skip to content

build: skip sast coverity check#2248

Merged
TenSt merged 1 commit into
RedHatInsights:masterfrom
TenSt:stepan/skip-sast-coverity-check
Jun 25, 2026
Merged

build: skip sast coverity check#2248
TenSt merged 1 commit into
RedHatInsights:masterfrom
TenSt:stepan/skip-sast-coverity-check

Conversation

@TenSt

@TenSt TenSt commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

This PR disables sast coverity check as it takes about 45m to run.
We will need to investigate how to configure it later to run faster and not block the pipeline.

Summary by Sourcery

Build:

  • Configure Tekton pull-request and push pipelines to set skip-sast-coverity-check to true, disabling the Coverity SAST step.

@TenSt TenSt requested a review from a team as a code owner June 25, 2026 16:50
@sourcery-ai

sourcery-ai Bot commented Jun 25, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the Tekton pipeline configurations for both pull request and push workflows to skip the SAST Coverity check by default, reducing pipeline execution time.

File-Level Changes

Change Details Files
Enable skipping of the SAST Coverity check in both PR and push Tekton pipelines.
  • Set the skip-sast-coverity-check parameter value to "true" in the pull request pipeline spec.
  • Set the skip-sast-coverity-check parameter value to "true" in the push pipeline spec.
.tekton/patchman-engine-pull-request.yaml
.tekton/patchman-engine-push.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Since this disables a security check globally, consider restricting the skip to specific branches or event types (e.g., only PRs) rather than both pull-request and push pipelines to reduce risk.
  • It may be helpful to add an inline TODO or comment next to skip-sast-coverity-check: "true" in the Tekton YAML so the intent and temporary nature of this change are visible to anyone editing the pipeline later.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since this disables a security check globally, consider restricting the skip to specific branches or event types (e.g., only PRs) rather than both pull-request and push pipelines to reduce risk.
- It may be helpful to add an inline TODO or comment next to `skip-sast-coverity-check: "true"` in the Tekton YAML so the intent and temporary nature of this change are visible to anyone editing the pipeline later.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov-commenter

codecov-commenter commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.03%. Comparing base (5b3c61d) to head (2d4afb5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2248      +/-   ##
==========================================
- Coverage   59.06%   59.03%   -0.04%     
==========================================
  Files         138      138              
  Lines        8848     8848              
==========================================
- Hits         5226     5223       -3     
- Misses       3076     3079       +3     
  Partials      546      546              
Flag Coverage Δ
unittests 59.03% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TenSt TenSt force-pushed the stepan/skip-sast-coverity-check branch from 1a262f8 to fc3b0db Compare June 25, 2026 17:13
@TenSt TenSt enabled auto-merge (squash) June 25, 2026 17:19
@TenSt TenSt force-pushed the stepan/skip-sast-coverity-check branch from fc3b0db to 2d4afb5 Compare June 25, 2026 17:32
@TenSt TenSt merged commit 92e5272 into RedHatInsights:master Jun 25, 2026
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants