#232 fix: fold time/timetz types in schema drift normalizer#233
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
entity_core::schema::normalizefoldstimestamptz/timestampto the spelled-outinformation_schema.data_typenames but had no arm fortime. ANaiveTimecolumn declaredTIMEnormalised totimewhileinformation_schemareportstime without time zone, soassert_schemaraised a falseTypeMismatchon a correct table.Fix
Add
time/time without time zoneandtimetz/time with time zonearms tonormalize, mirroring the existing timestamp handling. Unit testnormalize_folds_time_familycovers both spellings; module doc and the Best-Practices wiki page updated to list the date/time folding.Closes #232