Skip to content

#232 fix: fold time/timetz types in schema drift normalizer#233

Merged
RAprogramm merged 1 commit into
mainfrom
232
Jul 21, 2026
Merged

#232 fix: fold time/timetz types in schema drift normalizer#233
RAprogramm merged 1 commit into
mainfrom
232

Conversation

@RAprogramm

Copy link
Copy Markdown
Owner

Problem

entity_core::schema::normalize folds timestamptz/timestamp to the spelled-out information_schema.data_type names but had no arm for time. A NaiveTime column declared TIME normalised to time while information_schema reports time without time zone, so assert_schema raised a false TypeMismatch on a correct table.

Fix

Add time/time without time zone and timetz/time with time zone arms to normalize, mirroring the existing timestamp handling. Unit test normalize_folds_time_family covers both spellings; module doc and the Best-Practices wiki page updated to list the date/time folding.

Closes #232

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@RAprogramm
RAprogramm merged commit d699d7d into main Jul 21, 2026
17 checks passed
@RAprogramm
RAprogramm deleted the 232 branch July 21, 2026 00:19
@RAprogramm RAprogramm mentioned this pull request Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: schema drift normalizer treats time as drift vs time without time zone

1 participant