Simplify poseidon usage#571
Open
illuzen wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shouldn't change any hashes, but simplifies Header definition
depends on the new qp-poseidon PR Quantus-Network/qp-poseidon#74
Note
High Risk
Changes block header typing and Poseidon dependency wiring across runtime and consensus-critical
qp-header; a wrong hash would fork the chain despite the stability test.Overview
This PR drops the
qp-poseidoncrate from the workspace and standardizes onqp-poseidon-core2.0.2 (workspaceCargo.toml/ lockfile), removing that dependency from node, runtime, wormhole, mining-rewards, dilithium-crypto, and related crates.qp_header::Headeris simplified fromHeader<Number, BlockHashHasher, StateHasher>toHeader<Number, Hashing>: header fields and block hash areH256, Poseidon block hashing is implemented viaqp_poseidon_coreinsideqp-header, and the lone type parameter is the state trie / extrinsics root hasher (stillBlakeTwo256at runtime). Runtime and mocks now useHeader<BlockNumber, BlakeTwo256>instead ofPoseidonHasher+ Blake2.pallet-wormholeno longer depends onToFelts/qp_poseidonfor config bounds (native balance, asset id, transfer count, wormhole account id). Tests useBlakeTwo256forTestExternalitiesinstead ofPoseidonHasher.A consensus regression guard replaces the old dual-path hash comparison:
poseidon_header_hash_is_stableasserts a fixed devnet header hash (b7dbfd39…).Reviewed by Cursor Bugbot for commit a3cdcab. Bugbot is set up for automated code reviews on this repo. Configure here.