feat(browser): delegate MCP/noVNC runtime to rust-browser-connection#349
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #347.
This PR finishes the Rust-only browser/noVNC/MCP integration for docker-git:
docker-git-playwright-mcp/@playwright/mcpwrapper pathProverCoderAI/rust-browser-connectionwith an immutable pinned rev:c36f263ebc5d0acdf155113914f08cafefa69c56docker-git-browser-connectionfor browser lifecycle startupbrowser-connection--project <project-container>and--network container:<project-container>so MCP and noVNC share the same Rust-managed browser containerset -uby falling back from${DOCKER_GIT_PROJECT_CONTAINER_NAME:-}tohostnameRuntime proof
Fresh local smoke test against
/home/dev/rust-browser-connectionproved MCP + CDP + noVNC on the same Chromium/X11 session:dg-rust-browser-smoke-185718dg-rust-browser-smoke-185718-browser1MCP_NOVNC_RUNTIME_PROOF_1779649038browser-connection0.3.0browser_navigate,browser_snapshot,browser_evaluate,browser_click,browser_type,browser_press_key,browser_take_screenshotbrowser_evaluatereturned the marker from the page title/body/json/listreturned the same page title/URLRFB 003.008Local proof artifacts:
/tmp/dg-rust-browser-smoke-185718-proof/summary.txt/tmp/dg-rust-browser-smoke-185718-proof/mcp-verify-stdout.jsonl/tmp/dg-rust-browser-smoke-185718-proof/cdp-list.txt/tmp/dg-rust-browser-smoke-185718-proof/novnc-rfb.txt/tmp/dg-rust-browser-smoke-185718-proof/x11-framebuffer.pngVerification
Local checks after the final fixes:
bun run typecheck— passedbun run test— passed (52lib test files,267tests)bun run lint— passedgit diff --check— passed0findingsdocker-git-playwright-mcp/@playwright/mcp/ old browser runtime files outside negative tests and the implementation planNotes
The browser runtime remains in the separate
ProverCoderAI/rust-browser-connectionrepo. docker-git only installs and invokes the published Rust binaries; there is no local Rust source copy or TS browser-runtime duplication in this PR.