feat: hysteresis for oracle-health state transitions#793
Open
fadesany wants to merge 1 commit into
Open
Conversation
## Summary
Add hysteresis to `monitor_oracle_health` to prevent flapping on single-sample status changes.
Instead of flipping state on every probe, we now require N consecutive bad samples to mark
Degraded and M consecutive good samples to recover to Working.
## Changes
- **config.rs**: Added `ORACLE_HEALTH_DEGRADED_THRESHOLD` (3) and `ORACLE_HEALTH_RECOVERY_THRESHOLD` (3)
- **graceful_degradation.rs**:
- Added `consecutive_good` field to `OracleDegradationState`
- Rewrote `record_oracle_health` with hysteresis:
* 3 consecutive failures → Working → Degraded
* 3 consecutive successes → Degraded → Working
* Good sample resets failure counter; bad sample resets good counter
- `monitor_oracle_health` now routes samples through the hysteresis gate
- `OracleHealthStatusEvent` emitted only on actual state transitions
- **Tests**: 6 new hysteresis tests covering degradation, recovery, edge cases, event emission
## Acceptance Criteria
- ✅ No event emitted on no-op transitions
- ✅ Thresholds configurable in config.rs
- ✅ Tests cover both directions (degradation and recovery)
- ✅ No unwrap() introduced
- ✅ OracleHealth enum reused without breaking change
|
@fadesany Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add hysteresis to
monitor_oracle_healthto prevent flapping on single-sample status changes. Instead of flipping state on every probe, we now require N consecutive bad samples to mark Degraded and M consecutive good samples to recover to Working.Changes
ORACLE_HEALTH_DEGRADED_THRESHOLD(3) andORACLE_HEALTH_RECOVERY_THRESHOLD(3)consecutive_goodfield toOracleDegradationStaterecord_oracle_healthwith hysteresis:monitor_oracle_healthnow routes samples through the hysteresis gateOracleHealthStatusEventemitted only on actual state transitionscloses #623
Acceptance Criteria
Pull Request Description
📋 Basic Information
Type of Change
Please select the type of change this PR introduces:
Related Issues
Closes #(issue number)
Fixes #(issue number)
Related to #(issue number)
Priority Level
📝 Detailed Description
What does this PR do?
Why is this change needed?
How was this tested?
Alternative Solutions Considered
🏗️ Smart Contract Specific
Contract Changes
Please check all that apply:
Oracle Integration
Market Resolution Logic
Security Considerations
🧪 Testing
Test Coverage
Test Results
Manual Testing Steps
📚 Documentation
Documentation Updates
Breaking Changes
Breaking Changes:
Migration Guide:
🔍 Code Quality
Code Review Checklist
Performance Impact
Security Review
🚀 Deployment & Integration
Deployment Notes
Integration Points
📊 Impact Assessment
User Impact
Business Impact
✅ Final Checklist
Pre-Submission
Review Readiness
📸 Screenshots (if applicable)
🔗 Additional Resources
💬 Notes for Reviewers
Please pay special attention to:
Questions for reviewers:
Thank you for your contribution to Predictify! 🚀