test: require_auth coverage matrix as denylist#792
Open
Cent-Dave wants to merge 1 commit into
Open
Conversation
Add meta-tests to require_auth_coverage_tests.rs that enforce every state-mutating entrypoint in lib.rs calls require_auth for the expected signer (user or admin). Includes per-function meta_* tests and a single exhaustive denylist test as the canonical CI gate.
|
@Cent-Dave Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #626
PR Draft
Title
test: require_auth coverage matrix as denylistBody
Summary
Add a require_auth coverage matrix to require_auth_coverage_tests.rs to enforce that every state-mutating public entrypoint records the expected Soroban
require_authcall.What changed
assert_auth_recordedmeta_vote_records_user_authmeta_place_bet_records_user_authmeta_cancel_bet_records_user_authmeta_claim_winnings_records_user_authmeta_dispute_market_records_user_authmeta_vote_on_dispute_records_user_authmeta_create_market_records_admin_authmeta_resolve_market_manual_records_admin_authmeta_set_platform_fee_records_admin_authmeta_set_treasury_records_admin_authmeta_set_global_claim_period_records_admin_authmeta_set_market_claim_period_records_admin_authmeta_sweep_unclaimed_winnings_records_admin_authmeta_extend_deadline_records_admin_authmeta_collect_fees_records_admin_authmeta_withdraw_collected_fees_records_admin_authmeta_archive_event_records_admin_authmeta_add_admin_records_admin_authmeta_remove_admin_records_admin_authmeta_update_admin_role_records_admin_authmeta_request_resume_records_admin_authmeta_refund_on_oracle_failure_records_admin_authmeta_clear_monitor_overflow_records_admin_authmeta_set_global_bet_limits_records_admin_authmeta_set_oracle_val_cfg_global_records_admin_authmeta_admin_override_verification_records_admin_authmeta_update_event_description_records_admin_authtest_exhaustive_mutating_entrypoint_auth_denylistrequire_auth_coverage_testsin lib.rsWhy
This adds a CI-safe guard so new mutating entrypoints cannot be added without a corresponding auth check being verified by tests.
Testing
Run locally from repo root:
Notes
cargowas not available in the current environment for verification, so the branch and commit were created and pushed, but the test run should be completed locally.