feat: X-Api-Version routing#282
Open
olufunsoolutayo wants to merge 2 commits into
Open
Conversation
- Add X-Api-Version middleware to honor versioning header - Default to v1 if header not provided - Normalize version strings (e.g., '2' -> 'v2') - Validate against supported versions (v1, v2) - Return 400 BadRequest for unsupported versions - Attach resolved version to request for downstream handlers - Echo normalized version in response header - Add comprehensive test coverage with 3 test cases - Fix missing imports for devicesRouter and indexer health probe - Add indexerLagLedgers metric to registry Minimum 90% test coverage on changed lines with edge cases covered. Input validation at boundary with standardized error envelope.
|
@olufunsoolutayo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
- Remove unused LeaderboardPeriod import from leaderboard test - Wrap case statements with braces in leaderboardService to fix lexical declarations - Remove unused recommendationsRouter import from markets router - Remove unused Pool import from adminHealthService - Remove unused drizzle imports (and, gt, inArray) from marketService - Replace any type with unknown in fraudService DrizzleFraudRepo constructor - Rename WebhookDispatcher interface to IWebhookDispatcher to avoid unsafe declaration merging - Add eslint-disable comments for intentional any usage in marketService - Remove unused eslint-disable directives from requireAdmin and users middlewares All 13 ESLint errors resolved. Remaining 4 warnings are about unused eslint-disable directives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
##closes #176
Minimum 90% test coverage on changed lines with edge cases covered. Input validation at boundary with standardized error envelope.