Improve DSC expression grammar speed#1552
Open
SteveL-MSFT wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Small performance optimization to the tree-sitter grammar for DSC expressions. Makes regex patterns greedy (longest-match) since tree-sitter's lexer already prefers longest-match, removes redundant alternations, and inlines several helper rules to reduce parse tree overhead.
Changes:
- Added an
inlinedeclaration for_booleanLiteral,_argument,_quotedString, and_expressionStringso they are expanded at compile time. - Simplified regexes for
escapedStringLiteralandstringLiteralto greedy patterns (/.*/and/[^\[][\s\S]*/). - Removed the redundant
|\nbranch in thestringregex (already covered by[^']).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Small improvement to DSC expression parsing speed.
Before change: average speed: 3147 bytes/ms
After change: average speed: 3233 bytes/ms